chore(contexts): Simplify user context
#80704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeandher
changed the title
user contexuser context
github-actions
bot
added
the
Scope: Frontend
leeandher
commented
Nov 13, 2024
Comment on lines
+23
to
+31
| [UserContextKeys.GEO]?: Partial<Record<UserContextGeoKeys, string>>; | ||
| } | ||
|
|
||
| enum UserContextGeoKeys { | ||
| CITY = 'city', | ||
| COUNTRY_CODE = 'country_code', | ||
| SUBDIVISION = 'subdivision', | ||
| REGION = 'region', | ||
| } |
There was a problem hiding this comment.
I'm going to add these to the serializer since these are used all over but not rendered on issue details for some reason.
scttcper
approved these changes
Nov 13, 2024
Requires #80704 to render on issue details. These files are 6-8 years old, so I'm not really sure why this data wasn't exposed to the frontend via`get_api_context` (called by`EventSerializer` on 'group_event_details.py`) and this isn't releasing any new data. This data is actually already accessible via the event JSON. For example: - This issue says nothing about geo data in the UI ([link](https://demo.sentry.io/issues/6051030798/events/6d1970669234406c9806913e117982da/?project=5808623)) - But the JSON (via View JSON button) for the issue does ([link](https://us.sentry.io/api/0/projects/demo/react/events/6d1970669234406c9806913e117982da/json/)) <img width="418" alt="image" src="https://github.com/user-attachments/assets/c7f16a2c-4cc3-42a2-b6d9-97ff768be368">
github-actions
bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80704 +/- ##
==========================================
+ Coverage 74.24% 78.39% +4.14%
==========================================
Files 7204 7207 +3
Lines 319200 319371 +171
Branches 43967 43986 +19
==========================================
+ Hits 236994 250374 +13380
+ Misses 75716 62614 -13102
+ Partials 6490 6383 -107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #80420
12/13